Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add tests for more Playground apps #5294

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

radical
Copy link
Member

@radical radical commented Aug 14, 2024

  • Add milvus playground app to the tests.
  • Skip the redis commander in TestShop for tests, as it requires connecting to other containers which is not supported on our CI yet. And we don't really connect, and check the web app.
  • Reduce log level to debug from trace.
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 14, 2024
@radical radical added testing ☑️ and removed area-integrations Issues pertaining to Aspire Integrations packages labels Aug 14, 2024
@radical radical added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Aug 15, 2024
@radical radical marked this pull request as ready for review August 15, 2024 03:06
.WithDataVolume();

#if !SKIP_DASHBOARD_REFERENCE
basketCache.WithRedisCommander(c =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file has top-level statements, so zero indent. Or did you mean for the {..} block? Could you share the suggested indent in that case, and I can commit that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change in a follow up.

@radical radical merged commit 6173930 into dotnet:main Aug 15, 2024
11 checks passed
@radical radical deleted the more-playground-apps branch August 15, 2024 04:50
@radical radical mentioned this pull request Aug 15, 2024
35 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants